lkml.org 
[lkml]   [2020]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] pwm: core: Use octal permission
On Wed, Nov 18, 2020 at 08:21:12PM +0530, Soham Biswas wrote:
> Permission bits are easier readable in octal than with using the
> symbolic names.
>
> Fixes the following warning generated by checkpatch:
>
> drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are
> not preferred. Consider using octal permissions '0444'.
>
> +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
> &pwm_debugfs_fops);
>
> Signed-off-by: Soham Biswas <sohambiswas41@gmail.com>
> ---
> drivers/pwm/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks. Though I did unwrap the checkpatch warning message as
Uwe suggested.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-11-18 19:01    [W:0.269 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site