lkml.org 
[lkml]   [2020]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] pwm: core: Use octal permission
[added "v2" to the subject, would have been better if you had already
done that. I don't know if/how this confuses tools like b4 and patchwork]

Hello,

On Wed, Nov 18, 2020 at 04:17:30PM +0530, Soham Biswas wrote:
> Fixes the following warning generated by checkpatch:
>
> drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are
> not preferred. Consider using octal permissions '0444'.
>
> +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
> &pwm_debugfs_fops);

something like: "Permission bits are easier readable in octal than with
using the symbolic names." in the commit log would be good for those of
us who missed why this was added to checkpatch.

Best regards
Uwe


--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-11-18 13:44    [W:0.547 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site