Messages in this thread | | | From | Miguel Ojeda <> | Date | Mon, 16 Nov 2020 12:33:00 +0100 | Subject | Re: [PATCH 3/3] powerpc: fix -Wimplicit-fallthrough |
| |
On Mon, Nov 16, 2020 at 5:35 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > The "fallthrough" pseudo-keyword was added as a portable way to denote > intentional fallthrough. Clang will still warn on cases where there is a > fallthrough to an immediate break. Add explicit breaks for those cases. > > Link: https://github.com/ClangBuiltLinux/linux/issues/236 > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
It makes things clearer having a `break` added, so I like that warning.
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Cheers, Miguel
| |