lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] powerpc: fix -Wimplicit-fallthrough
    On Sun, Nov 15, 2020 at 08:35:32PM -0800, Nick Desaulniers wrote:
    > The "fallthrough" pseudo-keyword was added as a portable way to denote
    > intentional fallthrough. Clang will still warn on cases where there is a
    > fallthrough to an immediate break. Add explicit breaks for those cases.
    >
    > Link: https://github.com/ClangBuiltLinux/linux/issues/236
    > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

    Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
    Tested-by: Nathan Chancellor <natechancellor@gmail.com>

    > ---
    > arch/powerpc/kernel/prom_init.c | 1 +
    > arch/powerpc/kernel/uprobes.c | 1 +
    > arch/powerpc/perf/imc-pmu.c | 1 +
    > 3 files changed, 3 insertions(+)
    >
    > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
    > index 38ae5933d917..e9d4eb6144e1 100644
    > --- a/arch/powerpc/kernel/prom_init.c
    > +++ b/arch/powerpc/kernel/prom_init.c
    > @@ -355,6 +355,7 @@ static int __init prom_strtobool(const char *s, bool *res)
    > default:
    > break;
    > }
    > + break;
    > default:
    > break;
    > }
    > diff --git a/arch/powerpc/kernel/uprobes.c b/arch/powerpc/kernel/uprobes.c
    > index d200e7df7167..e8a63713e655 100644
    > --- a/arch/powerpc/kernel/uprobes.c
    > +++ b/arch/powerpc/kernel/uprobes.c
    > @@ -141,6 +141,7 @@ int arch_uprobe_exception_notify(struct notifier_block *self,
    > case DIE_SSTEP:
    > if (uprobe_post_sstep_notifier(regs))
    > return NOTIFY_STOP;
    > + break;
    > default:
    > break;
    > }
    > diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c
    > index 7b25548ec42b..e106909ff9c3 100644
    > --- a/arch/powerpc/perf/imc-pmu.c
    > +++ b/arch/powerpc/perf/imc-pmu.c
    > @@ -1500,6 +1500,7 @@ static int update_pmu_ops(struct imc_pmu *pmu)
    > pmu->pmu.stop = trace_imc_event_stop;
    > pmu->pmu.read = trace_imc_event_read;
    > pmu->attr_groups[IMC_FORMAT_ATTR] = &trace_imc_format_group;
    > + break;
    > default:
    > break;
    > }
    > --
    > 2.29.2.299.gdc1121823c-goog
    >

    \
     
     \ /
      Last update: 2020-11-17 04:03    [W:4.141 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site