lkml.org 
[lkml]   [2020]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND net-next 06/18] net: phy: marvell: remove the use of .ack_interrupt()
On Fri, Nov 13, 2020 at 06:52:14PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@nxp.com>
>
> In preparation of removing the .ack_interrupt() callback, we must replace
> its occurrences (aka phy_clear_interrupt), from the 2 places where it is
> called from (phy_enable_interrupts and phy_disable_interrupts), with
> equivalent functionality.
>
> This means that clearing interrupts now becomes something that the PHY
> driver is responsible of doing, before enabling interrupts and after
> clearing them. Make this driver follow the new contract.
>
> Cc: Maxim Kochetkov <fido_max@inbox.ru>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Robert Hancock <robert.hancock@calian.com>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Hi Ioana

I tested this series on a couple of Marvell Ethernet switches with
integrated PHYs using interrupts. Please feel free to add

Tested-by: Andrew Lunn <andrew@lunn.ch>

to this and the previous patch.

Andrew

\
 
 \ /
  Last update: 2020-11-15 21:59    [W:0.170 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site