lkml.org 
[lkml]   [2020]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip: ras/core] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
On Wed, Oct 07, 2020 at 01:14:47PM +0200, Borislav Petkov wrote:
> On Tue, Oct 06, 2020 at 09:57:09AM -0000, tip-bot2 for Dan Williams wrote:
> > + /* Copy successful. Return zero */
> > +.L_done_memcpy_trap:
> > + xorl %eax, %eax
> > +.L_done:
> > + ret
> > +SYM_FUNC_END(copy_mc_fragile)
> > +EXPORT_SYMBOL_GPL(copy_mc_fragile)
>
> That export together with CONFIG_MODVERSIONS causes
>
> WARNING: modpost: EXPORT symbol "copy_mc_fragile" [vmlinux] version generation failed, symbol will not be versioned.
>
> here.
>
> I don't see why tho...

It doesn't look like it is toolchain-specific and in both cases,
copy_mc_fragile's checksum is 0.

SUSE Leap 15.1:

Name : binutils
Version : 2.32-lp151.3.6.1

$ grep -E "(copy_mc_fragile|copy_user_generic_unrolled)" Module.symvers
0x00000000 copy_mc_fragile vmlinux EXPORT_SYMBOL_GPL
0xecdcabd2 copy_user_generic_unrolled vmlinux EXPORT_SYMBOL

debian testing:

Package: binutils
Version: 2.35-2

$ grep -E "(copy_mc_fragile|copy_user_generic_unrolled)" Module.symvers
0x00000000 copy_mc_fragile vmlinux EXPORT_SYMBOL_GPL
0xecdcabd2 copy_user_generic_unrolled vmlinux EXPORT_SYMBOL

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2020-10-07 18:46    [W:0.108 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site