lkml.org 
[lkml]   [2020]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [tip: ras/core] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
    [ add kbuild robot so they can add this check to their reports ]

    On Wed, Oct 7, 2020 at 9:47 AM Borislav Petkov <bp@alien8.de> wrote:
    >
    > On Wed, Oct 07, 2020 at 01:14:47PM +0200, Borislav Petkov wrote:
    > > On Tue, Oct 06, 2020 at 09:57:09AM -0000, tip-bot2 for Dan Williams wrote:
    > > > + /* Copy successful. Return zero */
    > > > +.L_done_memcpy_trap:
    > > > + xorl %eax, %eax
    > > > +.L_done:
    > > > + ret
    > > > +SYM_FUNC_END(copy_mc_fragile)
    > > > +EXPORT_SYMBOL_GPL(copy_mc_fragile)
    > >
    > > That export together with CONFIG_MODVERSIONS causes
    > >
    > > WARNING: modpost: EXPORT symbol "copy_mc_fragile" [vmlinux] version generation failed, symbol will not be versioned.
    > >
    > > here.
    > >
    > > I don't see why tho...
    >
    > It doesn't look like it is toolchain-specific and in both cases,
    > copy_mc_fragile's checksum is 0.
    >
    > SUSE Leap 15.1:
    >
    > Name : binutils
    > Version : 2.32-lp151.3.6.1
    >
    > $ grep -E "(copy_mc_fragile|copy_user_generic_unrolled)" Module.symvers
    > 0x00000000 copy_mc_fragile vmlinux EXPORT_SYMBOL_GPL
    > 0xecdcabd2 copy_user_generic_unrolled vmlinux EXPORT_SYMBOL
    >
    > debian testing:
    >
    > Package: binutils
    > Version: 2.35-2
    >
    > $ grep -E "(copy_mc_fragile|copy_user_generic_unrolled)" Module.symvers
    > 0x00000000 copy_mc_fragile vmlinux EXPORT_SYMBOL_GPL
    > 0xecdcabd2 copy_user_generic_unrolled vmlinux EXPORT_SYMBOL

    Yes, I'm seeing this too on Fedora, I'll take a look.

    \
     
     \ /
      Last update: 2020-10-07 19:53    [W:4.161 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site