Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] ima: Fix sizeof mismatches | Date | Wed, 7 Oct 2020 12:02:43 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
An incorrect sizeof is being used, sizeof(*fields) is not correct, it should be sizeof(**fields). This is not causing a problem since the size of these is the same. Fix this in the kmalloc_array and memcpy calls.
Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)") Fixes: 1bd7face7439 ("ima: allocate field pointers array on demand in template_desc_init_fields()") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- security/integrity/ima/ima_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/integrity/ima/ima_template.c b/security/integrity/ima/ima_template.c index 1e89e2d3851f..8884bbf03b43 100644 --- a/security/integrity/ima/ima_template.c +++ b/security/integrity/ima/ima_template.c @@ -216,11 +216,11 @@ int template_desc_init_fields(const char *template_fmt, } if (fields && num_fields) { - *fields = kmalloc_array(i, sizeof(*fields), GFP_KERNEL); + *fields = kmalloc_array(i, sizeof(**fields), GFP_KERNEL); if (*fields == NULL) return -ENOMEM; - memcpy(*fields, found_fields, i * sizeof(*fields)); + memcpy(*fields, found_fields, i * sizeof(**fields)); *num_fields = i; } -- 2.27.0
| |