Messages in this thread | | | Subject | Re: [PATCH v2 4/6] fpga: m10bmc-sec: expose max10 canceled keys in sysfs | From | Tom Rix <> | Date | Tue, 6 Oct 2020 10:41:14 -0700 |
| |
On 10/2/20 6:24 PM, Russ Weight wrote: > Extend the MAX10 BMC Security Engine driver to provide a > handler to expose the canceled code signing key (CSK) bit > vectors in sysfs. These use the standard bitmap list format > (e.g. 1,2-6,9). > > Signed-off-by: Russ Weight <russell.h.weight@intel.com> > --- > v2: > - Replaced small function-creation macros for explicit function > declarations. > - Fixed get_csk_vector() function to properly apply the stride > variable in calls to m10bmc_raw_bulk_read() > - Added m10bmc_ prefix to functions in m10bmc_iops structure
Looks ok to me.
Reviewed-by: Tom Rix <trix@redhat.com>
| |