Messages in this thread | | | Date | Mon, 5 Oct 2020 17:59:53 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] leds: lm3697: Fix out-of-bound access |
| |
Hi!
> On 10/5/20 8:57 AM, ultracoolguy@tutanota.com wrote: > > I agree with you. > > > > Attached patch with changes. > > Nack to the patch.
No need to do that, without matching From: and Signed-off, I can't really apply it...
> The subject says it does one thing but you also unnecessarily changed the > name of the structure. > > Renaming the structure does not fix the underlying issue
While I can't really apply it, it is fairly good bugreport. Can I get minimal patch to fix the problem, that can be cc-ed to stable, and that I can just apply with git am?
And yes, I believe renaming the structures to be non-confusing is a very good thing, but lets make it separate patch, so that stable backporting is easier.
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |