Messages in this thread | | | From | Daeho Jeong <> | Date | Tue, 27 Oct 2020 08:02:18 +0900 | Subject | Re: [PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl |
| |
I thought I gave the information about that in the commit message. Is this not enough for you? Actually, there is no space for F2FS ioctl documentation now. :(
2020년 10월 27일 (화) 오전 4:04, Eric Biggers <ebiggers@kernel.org>님이 작성: > > On Mon, Oct 26, 2020 at 01:16:55PM +0900, Daeho Jeong wrote: > > From: Daeho Jeong <daehojeong@google.com> > > > > Added a new F2FS_IOC_GET_COMPRESS_OPTION ioctl to get file compression > > option of a file. > > > > struct f2fs_comp_option { > > u8 algorithm; => compression algorithm > > => 0:lzo, 1:lz4, 2:zstd, 3:lzorle > > u8 log_cluster_size; => log scale cluster size > > => 2 ~ 8 > > }; > > > > struct f2fs_comp_option option; > > > > ioctl(fd, F2FS_IOC_GET_COMPRESS_OPTION, &option); > > > > Signed-off-by: Daeho Jeong <daehojeong@google.com> > > Reviewed-by: Eric Biggers <ebiggers@kernel.org> > > Please don't add Reviewed-by until it is explicitly given. > > The actual code looks fine, but there's still no mention of documentation, > tests, or use cases. > > - Eric
| |