lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl
On Mon, Oct 26, 2020 at 01:16:56PM +0900, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> Added a new F2FS_IOC_SET_COMPRESS_OPTION ioctl to change file
> compression option of a file.
>
> struct f2fs_comp_option {
> u8 algorithm; => compression algorithm
> => 0:lzo, 1:lz4, 2:zstd, 3:lzorle
> u8 log_cluster_size; => log scale cluster size
> => 2 ~ 8
> };
>
> struct f2fs_comp_option option;
>
> option.algorithm = 1;
> option.log_cluster_size = 7;
>
> ioctl(fd, F2FS_IOC_SET_COMPRESS_OPTION, &option);
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> Reviewed-by: Eric Biggers <ebiggers@kernel.org>

Likewise, please don't add Reviewed-by until it is explicitly given.

The code looks fine now, but this is still missing any explicit mention of
documentation, tests, or use cases.

> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

It's best not to use Reported-by for fixes that get folded in to a patch, since
Reported-by makes it seems like the patch itself is a bug fix. I recommend
mentioning folded-in fixes informally in the commit message instead, e.g.
"Folded in fix for build breakage reported by kernel test robot.".

- Eric

\
 
 \ /
  Last update: 2020-10-26 20:15    [W:0.090 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site