Messages in this thread | | | Date | Fri, 2 Oct 2020 11:58:29 -0700 | From | Nicolin Chen <> | Subject | Re: [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device() |
| |
On Fri, Oct 02, 2020 at 06:02:18PM +0300, Dmitry Osipenko wrote: > 02.10.2020 09:08, Nicolin Chen пишет: > > static int tegra_smmu_of_xlate(struct device *dev, > > struct of_phandle_args *args) > > { > > + struct platform_device *iommu_pdev = of_find_device_by_node(args->np); > > + struct tegra_mc *mc = platform_get_drvdata(iommu_pdev); > > u32 id = args->args[0]; > > > > + of_node_put(args->np); > > of_find_device_by_node() takes device reference and not the np > reference. This is a bug, please remove of_node_put().
Looks like so. Replacing it with put_device(&iommu_pdev->dev);
Thanks
| |