Messages in this thread | | | Subject | Re: [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device() | From | Dmitry Osipenko <> | Date | Fri, 2 Oct 2020 17:58:29 +0300 |
| |
02.10.2020 17:22, Dmitry Osipenko пишет: > 02.10.2020 09:08, Nicolin Chen пишет: >> -static void tegra_smmu_release_device(struct device *dev) >> -{ >> - dev_iommu_priv_set(dev, NULL); >> -} >> +static void tegra_smmu_release_device(struct device *dev) {} > > Please keep the braces as-is. >
I noticed that you borrowed this style from the sun50i-iommu driver, but this is a bit unusual coding style for the c files. At least to me it's unusual to see header-style function stub in a middle of c file. But maybe it's just me.
| |