Messages in this thread | | | Date | Fri, 16 Oct 2020 07:17:57 +0200 | From | Greg KH <> | Subject | Re: [PATCH] Staging: android: ashmem: changed struct file_operations to const file_operations |
| |
On Fri, Oct 16, 2020 at 01:11:11AM -0400, kiransuren@osuosl.org wrote: > From: kiransuren <kirank.suren@gmail.com>
This does not match your signed-off-by line :(
> > Fixed a coding style issue.
What issue? Always be specific.
> > Signed-off-by: Kiran Surendran <kirank.suren@gmail.com> > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index 10b4be1f3e78..f2b67c4fe8d2 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const file_operations vmfile_fops;
Why did you not test-build your patch before sending it out?
Don't you think that is a big rude?
Please be more careful.
greg k-h
| |