Messages in this thread | | | From | linmiaohe <> | Subject | Re: [PATCH] KVM: X86: Add 'else' to unify fastop and execute call path | Date | Wed, 22 Jan 2020 06:41:36 +0000 |
| |
Hi: Sean Christopherson <sean.j.christopherson@intel.com> wrote: > On Wed, Jan 22, 2020 at 11:21:44AM +0800, linmiaohe wrote: >> From: Miaohe Lin <linmiaohe@huawei.com> >> >> It also helps eliminate some duplicated code. > > Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
Thanks for your review.
> >> if (ctxt->d & Fastop) { >> void (*fop)(struct fastop *) = (void *)ctxt->execute; > >The brackets can also be removed with a bit more cleanup, e.g. using a typedef to handling casting ctxt->execute. I'll send a patch that can be applied on top and/or squashed with this one.
Thanks for doing this. :)
> >> rc = fastop(ctxt, fop);
| |