Messages in this thread | | | Date | Mon, 20 Jan 2020 11:17:20 +0100 | From | Michal Hocko <> | Subject | Re: [Patch v2 2/4] mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison |
| |
On Mon 20-01-20 11:04:13, Wei Yang wrote: > Since function returns directly, bad_[reason|flags] is not used any > where. > > This is a following cleanup for commit e570f56cccd21 ("mm: > check_new_page_bad() directly returns in __PG_HWPOISON case") > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > Acked-by: David Rientjes <rientjes@google.com>
This is a left over from loong time ago. AFAICS bad_reason and flags hav never been used.
Acked-by: Michal Hocko <mhocko@suse.com>
> --- > mm/page_alloc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 0cf6218aaba7..a43b9d2482f2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2051,8 +2051,6 @@ static void check_new_page_bad(struct page *page) > if (unlikely(page_ref_count(page) != 0)) > bad_reason = "nonzero _refcount"; > if (unlikely(page->flags & __PG_HWPOISON)) { > - bad_reason = "HWPoisoned (hardware-corrupted)"; > - bad_flags = __PG_HWPOISON; > /* Don't complain about hwpoisoned pages */ > page_mapcount_reset(page); /* remove PageBuddy */ > return; > -- > 2.17.1
-- Michal Hocko SUSE Labs
| |