lkml.org 
[lkml]   [2020]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Patch v2 2/4] mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison
    From
    Date
    On 20.01.20 04:04, Wei Yang wrote:
    > Since function returns directly, bad_[reason|flags] is not used any
    > where.
    >
    > This is a following cleanup for commit e570f56cccd21 ("mm:
    > check_new_page_bad() directly returns in __PG_HWPOISON case")
    >
    > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
    > Acked-by: David Rientjes <rientjes@google.com>
    > ---
    > mm/page_alloc.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
    > index 0cf6218aaba7..a43b9d2482f2 100644
    > --- a/mm/page_alloc.c
    > +++ b/mm/page_alloc.c
    > @@ -2051,8 +2051,6 @@ static void check_new_page_bad(struct page *page)
    > if (unlikely(page_ref_count(page) != 0))
    > bad_reason = "nonzero _refcount";
    > if (unlikely(page->flags & __PG_HWPOISON)) {
    > - bad_reason = "HWPoisoned (hardware-corrupted)";
    > - bad_flags = __PG_HWPOISON;
    > /* Don't complain about hwpoisoned pages */
    > page_mapcount_reset(page); /* remove PageBuddy */
    > return;
    >

    Reviewed-by: David Hildenbrand <david@redhat.com>

    --
    Thanks,

    David / dhildenb

    \
     
     \ /
      Last update: 2020-01-20 13:21    [W:3.480 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site