Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH][next][V2] drivers/misc: ti-st: remove redundant assignment to variables i and flags | Date | Mon, 13 Jan 2020 12:31:49 +0000 |
| |
From: Colin Ian King <colin.king@canonical.com>
The variables i and flags are being initialized with values that are never read. The initializations are redundant and can be removed.
Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> ---
V2: remove assignment to flags too, thanks to Dan Carpenter for spotting that.
--- drivers/misc/ti-st/st_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index 2ae9948a91e1..14136d2cc8f9 100644 --- a/drivers/misc/ti-st/st_core.c +++ b/drivers/misc/ti-st/st_core.c @@ -736,8 +736,8 @@ static int st_tty_open(struct tty_struct *tty) static void st_tty_close(struct tty_struct *tty) { - unsigned char i = ST_MAX_CHANNELS; - unsigned long flags = 0; + unsigned char i; + unsigned long flags; struct st_data_s *st_gdata = tty->disc_data; pr_info("%s ", __func__); -- 2.24.0
| |