Messages in this thread | | | Subject | Re: [PATCH] perf tools: Fix bug when recording SPE and non SPE events | From | Suzuki Kuruppassery Poulose <> | Date | Mon, 13 Jan 2020 12:28:11 +0000 |
| |
On 20/12/2019 11:05, James Clark wrote: > This patch fixes an issue when non Arm SPE events are specified after an > Arm SPE event. In that case, perf will exit with an error code and not > produce a record file. This is because a loop index is used to store the > location of the relevant Arm SPE PMU, but if non SPE PMUs follow, that > index will be overwritten. Fix this issue by saving the PMU into a > variable instead of using the index, and also add an error message. > > Before the fix: > ./perf record -e arm_spe/ts_enable=1/ -e branch-misses ls; echo $? > 237 > > After the fix: > ./perf record -e arm_spe/ts_enable=1/ -e branch-misses ls; echo $? > ... > 0 > > Signed-off-by: James Clark <james.clark@arm.com> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Cc: Suzuki K Poulose <suzuki.poulose@arm.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> > Cc: Jiri Olsa <jolsa@redhat.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Igor Lubashev <ilubashe@akamai.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
| |