Messages in this thread | | | Date | Mon, 13 Jan 2020 11:17:15 +0100 | From | Christian Brauner <> | Subject | Re: [PATCH] m68k: Wire up clone3() syscall |
| |
On Mon, Jan 13, 2020 at 10:34:35AM +0100, Geert Uytterhoeven wrote: > Hi Christian, > > On Mon, Jan 13, 2020 at 10:18 AM Christian Brauner > <christian.brauner@ubuntu.com> wrote: > > On Mon, Jan 13, 2020 at 10:10:26AM +0100, Geert Uytterhoeven wrote: > > > On Sun, Jan 12, 2020 at 5:06 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > On Sun, Nov 24, 2019 at 8:52 PM Kars de Jong <jongk@linux-m68k.org> wrote: > > > > > Wire up the clone3() syscall for m68k. The special entry point is done in > > > > > assembler as was done for clone() as well. This is needed because all > > > > > registers need to be saved. The C wrapper then calls the generic > > > > > sys_clone3() with the correct arguments. > > > > > > > > > > Tested on A1200 using the simple test program from: > > > > > > > > > > https://lore.kernel.org/lkml/20190716130631.tohj4ub54md25dys@brauner.io/ > > > > > > > > > > Cc: linux-m68k@vger.kernel.org > > > > > Signed-off-by: Kars de Jong <jongk@linux-m68k.org> > > > > > > > > Thanks, applied and queued for v5.6. > > > > > > Which is now broken because of commit dd499f7a7e342702 ("clone3: ensure > > > copy_thread_tls is implemented") in v5.5-rc6 :-( > > > > Sorry, just for clarification what and how is it broken by > > dd499f7a7e342702 ("clone3: ensure > copy_thread_tls is implemented") > > ? > > Because m68k does not implement copy_thread_tls() yet, and doesn't > select HAVE_COPY_THREAD_TLS yet.
Oh right, sorry. I forgot that m68k has a patchset to enable clone3() up for merging. I should've remembered that and warned you that we will have to require copy_thread_tls() going forward. I hope the merge is explanatory enough why we're doing it this way.
> > Looking into fixing that...
Thank you! Much appreciated! Christian
| |