Messages in this thread | | | Date | Mon, 13 Jan 2020 10:18:14 +0100 | From | Christian Brauner <> | Subject | Re: [PATCH] m68k: Wire up clone3() syscall |
| |
On Mon, Jan 13, 2020 at 10:10:26AM +0100, Geert Uytterhoeven wrote: > On Sun, Jan 12, 2020 at 5:06 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Sun, Nov 24, 2019 at 8:52 PM Kars de Jong <jongk@linux-m68k.org> wrote: > > > Wire up the clone3() syscall for m68k. The special entry point is done in > > > assembler as was done for clone() as well. This is needed because all > > > registers need to be saved. The C wrapper then calls the generic > > > sys_clone3() with the correct arguments. > > > > > > Tested on A1200 using the simple test program from: > > > > > > https://lore.kernel.org/lkml/20190716130631.tohj4ub54md25dys@brauner.io/ > > > > > > Cc: linux-m68k@vger.kernel.org > > > Signed-off-by: Kars de Jong <jongk@linux-m68k.org> > > > > Thanks, applied and queued for v5.6. > > Which is now broken because of commit dd499f7a7e342702 ("clone3: ensure > copy_thread_tls is implemented") in v5.5-rc6 :-(
Sorry, just for clarification what and how is it broken by dd499f7a7e342702 ("clone3: ensure > copy_thread_tls is implemented") ?
> > BTW, was this the reason for the failures at the end of > https://lore.kernel.org/lkml/CACz-3rhmUfxbfhznvA6NOF69SR49NDZwnkZ=Bmhw_cf4SkiadQ@mail.gmail.com/?
Unlikely since CLONE_SETTLS is currently not covered by the clone3()/process creation test suite because it is highly arch dependent on how to retrieve the tls pointer. But we're going to add tests soon I hope.
Thanks! Christian
| |