Messages in this thread | | | From | linmiaohe <> | Subject | Re: [PATCH][next] ath11k: avoid null pointer dereference when pointer band is null | Date | Sat, 11 Jan 2020 09:50:12 +0000 |
| |
Colin Ian King <colin.king@canonical.com> wrote: >From: Colin Ian King <colin.king@canonical.com> > >In the unlikely event that cap->supported_bands has neither WMI_HOST_WLAN_2G_CAP set or WMI_HOST_WLAN_5G_CAP set then pointer band is null and a null dereference occurs when assigning >band->n_iftype_data. Move the assignment to the if blocks to >avoid this. Cleans up static analysis warnings. > >Addresses-Coverity: ("Explicit null dereference") >Fixes: 9f056ed8ee01 ("ath11k: add HE support") >Signed-off-by: Colin Ian King <colin.king@canonical.com> >--- > drivers/net/wireless/ath/ath11k/mac.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)
It looks fine for me. Thanks. Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
| |