Messages in this thread Patch in this message | | | From | Navid Emamdoost <> | Subject | [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids | Date | Wed, 25 Sep 2019 11:19:19 -0500 |
| |
In snd_skl_parse_uuids if allocation for module->instance_id fails, the allocated memory for module shoulde be released. I changes the allocation for module to use devm_kzalloc to be resource_managed allocation and avoid the release in error path.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> --- Changes in v2: - Changed the allocation for module from kzalloc to devm_kzalloc --- sound/soc/intel/skylake/skl-sst-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-sst-utils.c b/sound/soc/intel/skylake/skl-sst-utils.c index d43cbf4a71ef..ac37f04b0eea 100644 --- a/sound/soc/intel/skylake/skl-sst-utils.c +++ b/sound/soc/intel/skylake/skl-sst-utils.c @@ -284,7 +284,7 @@ int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, */ for (i = 0; i < num_entry; i++, mod_entry++) { - module = kzalloc(sizeof(*module), GFP_KERNEL); + module = devm_kzalloc(ctx->dev, sizeof(*module), GFP_KERNEL); if (!module) { ret = -ENOMEM; goto free_uuid_list; -- 2.17.1
| |