Messages in this thread | | | Subject | Re: [PATCH bpf-next 01/11] samples: bpf: makefile: fix HDR_PROBE "echo" | From | Sergei Shtylyov <> | Date | Wed, 11 Sep 2019 14:02:11 +0300 |
| |
On 10.09.2019 17:54, Ivan Khoronzhuk wrote:
>> Hello! >> >> On 10.09.2019 13:38, Ivan Khoronzhuk wrote: >> >>> echo should be replaced on echo -e to handle \n correctly, but instead, >> >> s/on/with/? > s/echo/printf/ instead of s/echo/echo -e/
I only pointed that 'on' is incorrect there. You replace something /with/ something other...
> > printf looks better. > >> >>> replace it on printf as some systems can't handle echo -e. >> >> Likewise?
Same grammatical mistake.
> I can guess its Mac vs Linux, but it does mean nothing if it's defined as > implementation dependent, can be any. > >>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> >> [...]
MBR, Sergei
| |