Messages in this thread | | | Date | Tue, 10 Sep 2019 17:54:01 +0300 | From | Ivan Khoronzhuk <> | Subject | Re: [PATCH bpf-next 01/11] samples: bpf: makefile: fix HDR_PROBE "echo" |
| |
On Tue, Sep 10, 2019 at 01:46:48PM +0300, Sergei Shtylyov wrote: >Hello! > >On 10.09.2019 13:38, Ivan Khoronzhuk wrote: > >>echo should be replaced on echo -e to handle \n correctly, but instead, > > s/on/with/? s/echo/printf/ instead of s/echo/echo -e/
printf looks better.
> >>replace it on printf as some systems can't handle echo -e. > > Likewise? Like some, better avoid ambiguity, for me it works fine - is not enough. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html "A string to be written to standard output. If the first operand is -n, or if any of the operands contain a <backslash> character, the results are implementation-defined"
I can guess its Mac vs Linux, but it does mean nothing if it's defined as implementation dependent, can be any.
> >>Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> >[...] > >MBR, Sergei >
-- Regards, Ivan Khoronzhuk
| |