Messages in this thread | | | Subject | Re: [PATCH V2 net-next 4/7] net: hns3: fix port setting handle for fibre port | From | Sergei Shtylyov <> | Date | Wed, 11 Sep 2019 13:16:52 +0300 |
| |
Hello!
On 11.09.2019 5:40, Huazhong Tan wrote:
> From: Guangbin Huang <huangguangbin2@huawei.com> > > For hardware doesn't support use specified speed and duplex
Can't pasre that. "For hardware that does not support using", perhaps?
> to negotiate, it's unnecessary to check and modify the port > speed and duplex for fibre port when autoneg is on. > > Fixes: 22f48e24a23d ("net: hns3: add autoneg and change speed support for fibre port") > Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com> > Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com> > --- > drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c > index f5a681d..680c350 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c > @@ -726,6 +726,12 @@ static int hns3_check_ksettings_param(const struct net_device *netdev, > u8 duplex; > int ret; > > + /* hw doesn't support use specified speed and duplex to negotiate,
I can't parse that, did you mean "using"?
> + * unnecessary to check them when autoneg on. > + */ > + if (cmd->base.autoneg) > + return 0; > + > if (ops->get_ksettings_an_result) { > ops->get_ksettings_an_result(handle, &autoneg, &speed, &duplex); > if (cmd->base.autoneg == autoneg && cmd->base.speed == speed && > @@ -787,6 +793,15 @@ static int hns3_set_link_ksettings(struct net_device *netdev, > return ret; > } > > + /* hw doesn't support use specified speed and duplex to negotiate,
Here too...
> + * ignore them when autoneg on. > + */ > + if (cmd->base.autoneg) { > + netdev_info(netdev, > + "autoneg is on, ignore the speed and duplex\n"); > + return 0; > + } > + > if (ops->cfg_mac_speed_dup_h) > ret = ops->cfg_mac_speed_dup_h(handle, cmd->base.speed, > cmd->base.duplex);
MBR, Sergei
| |