Messages in this thread | | | From | Seunghun Han <> | Date | Wed, 11 Sep 2019 14:17:48 +0900 | Subject | Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs |
| |
> > And why is this allocating memory inside the acpi table walker? It > > seems to me like the memory should be allocated once the mapping is > > made. > > > > Yes, this looks bad. Letting the walker build the list and then using > it is, probably, a better idea. > > > Maybe all the mappings should be created from the ACPI ranges right > > away? > > > > I don't know if it's a good idea to just map them all instead of doing > so only for relevant ones. Maybe it is safe, here I need an advice > from a more knowledgeable person. >
Vanya, I also made a patch series to solve AMD's fTPM. My patch link is here, https://lkml.org/lkml/2019/9/9/132 .
The maintainer, Jarkko, wanted me to remark on your patch, so I would like to cooperate with you.
Your patch is good for me. If you are fine, I would like to take your patch and merge it with my patch series. I also would like to change some points Jason mentioned before.
Of course, I will leave your commit message and sign-off-by note. According to the guideline below, I will just add co-developed-by and sign-off-by notes behind you. https://www.kernel.org/doc/html/v5.2/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
If you have any idea about our co-work, please let me know. I hope we can solve AMD's fTPM problem soon.
Seunghun
| |