Messages in this thread Patch in this message | | | From | "Valdis Klētnieks" <> | Subject | [PATCH] scripts/checkpatch.pl - fix *_NOTIFIER_HEAD handling | Date | Wed, 07 Aug 2019 21:36:21 -0400 |
| |
commit 81398d99e9de80d9dbe65dfe7aadec9497f88242 Author: Gilad Ben-Yossef <gilad@benyossef.com> Date: Wed Jul 31 14:44:23 2019 +1000
checkpatch: add *_NOTIFIER_HEAD as var definition
has a typo, resulting in a truly amazing error message:
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/(?: \n.}\s*$| ^.DEFINE_(?^x: [A-Za-z_][A-Za-z\d_]* (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)* )\(rtl_usb_probe\)| ^.DECLARE_(?^x: [A-Za-z_][A-Za-z\d_]* (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)* )\(rtl_usb_probe\)| ^.LIST_HEAD\(rtl_usb_probe\)| ^.{ <-- HERE (?^x: [A-Za-z_][A-Za-z\d_]* (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)* )}_NOTIFIER_HEAD\(rtl_usb_probe\)|
(Rexexp dump continues for 236 lines total)
Fix the typo.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 5c00151cdee8..dd095d1e5a19 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3891,7 +3891,7 @@ sub process { ^.DEFINE_$Ident\(\Q$name\E\)| ^.DECLARE_$Ident\(\Q$name\E\)| ^.LIST_HEAD\(\Q$name\E\)| - ^.{$Ident}_NOTIFIER_HEAD\(\Q$name\E\)| + ^.${Ident}_NOTIFIER_HEAD\(\Q$name\E\)| ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(| \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\() )/x) {
| |