lkml.org 
[lkml]   [2019]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC V1 RESEND 3/6] x86: Introduce the dynamic teardown function
From
Date
On Sat, 2019-06-29 at 10:01 +0200, Thomas Gleixner wrote:
> Megha,
>
> On Fri, 21 Jun 2019, Megha Dey wrote:
> >
> >  
> > +void default_teardown_msi_irqs_grp(struct pci_dev *dev, int
> > group_id)
> > +{
> > + int i;
> > + struct msi_desc *entry;
> > +
> > + for_each_pci_msi_entry(entry, dev) {
> > + if (entry->group_id == group_id && entry->irq) {
> > + for (i = 0; i < entry->nvec_used; i++)
> > + arch_teardown_msi_irq(entry->irq +
> > i);
> With proper group management this whole group_id muck goes away. You
> hand
> in a group and clean it up and if done right then you don't need a
> new
> interface at all simply because everything is group based.
>

Yeah , with the new proposal, this will hopefully be much cleaner.

> Thanks,
>
> tglx

\
 
 \ /
  Last update: 2019-08-06 20:46    [W:0.055 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site