Messages in this thread | | | Date | Sat, 29 Jun 2019 10:01:43 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [RFC V1 RESEND 3/6] x86: Introduce the dynamic teardown function |
| |
Megha,
On Fri, 21 Jun 2019, Megha Dey wrote: > > +void default_teardown_msi_irqs_grp(struct pci_dev *dev, int group_id) > +{ > + int i; > + struct msi_desc *entry; > + > + for_each_pci_msi_entry(entry, dev) { > + if (entry->group_id == group_id && entry->irq) { > + for (i = 0; i < entry->nvec_used; i++) > + arch_teardown_msi_irq(entry->irq + i);
With proper group management this whole group_id muck goes away. You hand in a group and clean it up and if done right then you don't need a new interface at all simply because everything is group based.
Thanks,
tglx
| |