Messages in this thread | | | Date | Wed, 28 Aug 2019 10:52:17 +0200 | From | Peter Zijlstra <> | Subject | Re: [RESEND PATCH V3 2/8] perf/x86/intel: Basic support for metrics counters |
| |
On Mon, Aug 26, 2019 at 07:47:34AM -0700, kan.liang@linux.intel.com wrote: > +#define INTEL_PMC_IDX_FIXED_METRIC_BASE (INTEL_PMC_IDX_FIXED + 16) > +#define INTEL_PMC_IDX_TD_RETIRING (INTEL_PMC_IDX_FIXED_METRIC_BASE + 0) > +#define INTEL_PMC_IDX_TD_BAD_SPEC (INTEL_PMC_IDX_FIXED_METRIC_BASE + 1) > +#define INTEL_PMC_IDX_TD_FE_BOUND (INTEL_PMC_IDX_FIXED_METRIC_BASE + 2) > +#define INTEL_PMC_IDX_TD_BE_BOUND (INTEL_PMC_IDX_FIXED_METRIC_BASE + 3) > +#define INTEL_PMC_MSK_TOPDOWN ((0xfull << INTEL_PMC_IDX_FIXED_METRIC_BASE) | \ > + INTEL_PMC_MSK_FIXED_SLOTS)
> + > +#define INTEL_PMC_CLEAR_TOPDOWN_BIT(bit) (~(0x1ull << bit) & INTEL_PMC_MSK_TOPDOWN)
That thing is a clear misnomer; it is OTHER_TOPDOWN_BITS(). Fixed that too.
| |