lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Virtio-fs] [PATCH 04/19] virtio: Implement get_shm_region for PCI transport
From
Date


On 2019/8/26 21:06, Vivek Goyal wrote:
> On Mon, Aug 26, 2019 at 09:43:08AM +0800, piaojun wrote:
>
> [..]
>>> +static bool vp_get_shm_region(struct virtio_device *vdev,
>>> + struct virtio_shm_region *region, u8 id)
>>> +{
>>> + struct virtio_pci_device *vp_dev = to_vp_device(vdev);
>>> + struct pci_dev *pci_dev = vp_dev->pci_dev;
>>> + u8 bar;
>>> + u64 offset, len;
>>> + phys_addr_t phys_addr;
>>> + size_t bar_len;
>>> + char *bar_name;
>>
>> 'char *bar_name' should be cleaned up to avoid compiling warning. And I
>> wonder if you mix tab and blankspace for code indent? Or it's just my
>> email display problem?
>
> Will get rid of now unused bar_name.
>
OK

> Generally git flags if there are tab/space issues. I did not see any. So
> if you see something, point it out and I will fix it.
>

cohuck found the same indent problem and pointed them in another email.

Jun

\
 
 \ /
  Last update: 2019-08-27 11:42    [W:0.997 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site