Messages in this thread | | | Date | Mon, 26 Aug 2019 09:06:07 -0400 | From | Vivek Goyal <> | Subject | Re: [Virtio-fs] [PATCH 04/19] virtio: Implement get_shm_region for PCI transport |
| |
On Mon, Aug 26, 2019 at 09:43:08AM +0800, piaojun wrote:
[..] > > +static bool vp_get_shm_region(struct virtio_device *vdev, > > + struct virtio_shm_region *region, u8 id) > > +{ > > + struct virtio_pci_device *vp_dev = to_vp_device(vdev); > > + struct pci_dev *pci_dev = vp_dev->pci_dev; > > + u8 bar; > > + u64 offset, len; > > + phys_addr_t phys_addr; > > + size_t bar_len; > > + char *bar_name; > > 'char *bar_name' should be cleaned up to avoid compiling warning. And I > wonder if you mix tab and blankspace for code indent? Or it's just my > email display problem?
Will get rid of now unused bar_name.
Generally git flags if there are tab/space issues. I did not see any. So if you see something, point it out and I will fix it.
Vivek
| |