Messages in this thread | | | From | "Oliver O'Halloran" <> | Date | Wed, 28 Aug 2019 09:24:51 +1000 | Subject | Re: [PATCH v3 1/4] PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators |
| |
On Tue, Aug 20, 2019 at 2:17 AM Denis Efremov <efremov@linux.com> wrote: > > Hi, > > On 8/19/19 7:06 PM, Denis Efremov wrote: > On 8/12/19 11:25 AM, sathyanarayanan kuppuswamy wrote: > > Do we need to switch case here ? if (pwr > 0) {} should work right ? > > I saved the switch here from v2. I think switch makes the inputs check more > precise and filters-out all non-valid values. Maybe this check is too strict?
Sounds like you're overthinking it tbh. If want to catch programming errors then a WARN_ON_ONCE() in the default case would be better than silently ignoring invalid values, but it's pretty hard to care.
> We could use mask here ON|OFF|BLINK for the check, but I don't know how hardware > will handle a case, for example, pwr == ON|BLINK.
ON|BLINK is the same as OFF
| |