lkml.org 
[lkml]   [2019]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 1/4] PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators
    From
    Date
    Hi,

    On 8/19/19 7:06 PM, Denis Efremov wrote:
    > + switch (pwr) {
    > + case PCI_EXP_SLTCTL_PWR_IND_ON:
    > + case PCI_EXP_SLTCTL_PWR_IND_BLINK:
    > + case PCI_EXP_SLTCTL_PWR_IND_OFF:
    > + cmd |= pwr;
    > + mask |= PCI_EXP_SLTCTL_PIC;
    > + }
    > +

    On 8/12/19 11:25 AM, sathyanarayanan kuppuswamy wrote:
    > Do we need to switch case here ? if (pwr > 0) {} should work right ?

    I saved the switch here from v2. I think switch makes the inputs check more
    precise and filters-out all non-valid values. Maybe this check is too strict?

    We could use mask here ON|OFF|BLINK for the check, but I don't know how hardware
    will handle a case, for example, pwr == ON|BLINK.

    Thanks,
    Denis

    \
     
     \ /
      Last update: 2019-08-19 18:17    [W:2.252 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site