Messages in this thread | | | Date | Wed, 28 Aug 2019 01:10:00 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c |
| |
On Tue, Aug 27, 2019 at 03:01:03PM -0700, David Miller wrote: > From: Marco Hartmann <marco.hartmann@nxp.com> > Date: Wed, 21 Aug 2019 11:00:46 +0000 > > > Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling > > genphy_config_aneg") introduced a check that aborts phy_config_aneg() > > if the phy is a C45 phy. > > This causes phy_state_machine() to call phy_error() so that the phy > > ends up in PHY_HALTED state. > > > > Instead of returning -EOPNOTSUPP, call genphy_c45_config_aneg() > > (analogous to the C22 case) so that the state machine can run > > correctly. > > > > genphy_c45_config_aneg() closely resembles mv3310_config_aneg() > > in drivers/net/phy/marvell10g.c, excluding vendor specific > > configurations for 1000BaseT. > > > > Fixes: 22b56e827093 ("net: phy: replace genphy_10g_driver with genphy_c45_driver") > > > > Signed-off-by: Marco Hartmann <marco.hartmann@nxp.com> > > Andrew, gentle ping to respond to Heiner who said:
It at least makes it consistent with phy_restart_aneg() and phy_aneg_done().
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |