Messages in this thread | | | Date | Mon, 26 Aug 2019 16:01:31 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs |
| |
On Mon, Aug 26, 2019 at 09:23:36AM -0400, Nayna Jain wrote: > +static struct bin_attribute update_attr = { > + .attr = {.name = "update", .mode = 0200}, > + .size = VARIABLE_MAX_SIZE, > + .write = update_write, > +};
Ah, do we need a __BIN_ATTR_WO() macro for you? That would make this more obvious, right?
Other than that minor thing (not a complaint at all) looks much better to me, nice work:
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |