lkml.org 
[lkml]   [2019]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 3/4] x86/efi: move common keyring handler functions to new file
    From
    Date
    (Cc'ing Josh Boyer, David Howells)

    On Mon, 2019-09-02 at 21:55 +1000, Michael Ellerman wrote:
    > Nayna Jain <nayna@linux.ibm.com> writes:
    >
    > > The handlers to add the keys to the .platform keyring and blacklisted
    > > hashes to the .blacklist keyring is common for both the uefi and powerpc
    > > mechanisms of loading the keys/hashes from the firmware.
    > >
    > > This patch moves the common code from load_uefi.c to keyring_handler.c
    > >
    > > Signed-off-by: Nayna Jain <nayna@linux.ibm.com>

    Acked-by: Mimi Zohar <zohar@linux.ibm.com>

    > > ---
    > > security/integrity/Makefile | 3 +-
    > > .../platform_certs/keyring_handler.c | 80 +++++++++++++++++++
    > > .../platform_certs/keyring_handler.h | 32 ++++++++
    > > security/integrity/platform_certs/load_uefi.c | 67 +---------------
    > > 4 files changed, 115 insertions(+), 67 deletions(-)
    > > create mode 100644 security/integrity/platform_certs/keyring_handler.c
    > > create mode 100644 security/integrity/platform_certs/keyring_handler.h
    >
    > This has no acks from security folks, though I'm not really clear on who
    > maintains those files.

    I upstreamed David's, Josh's, and Nayna's patches, so that's probably
    me.

    > Do I take it because it's mostly just code movement people are OK with
    > it going in via the powerpc tree?

    Yes, the only reason for splitting load_uefi.c is for powerpc.  These
    patches should be upstreamed together.  

    Mimi

    \
     
     \ /
      Last update: 2019-09-04 00:53    [W:3.289 / U:1.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site