Messages in this thread | | | Date | Sat, 17 Aug 2019 09:03:42 -0700 | From | Richard Cochran <> | Subject | Re: [PATCH 2/2] PTP: add support for one-shot output |
| |
On Wed, Aug 14, 2019 at 10:47:12AM +0300, Felipe Balbi wrote: > diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h > index 039cd62ec706..9412b16cc8ed 100644 > --- a/include/uapi/linux/ptp_clock.h > +++ b/include/uapi/linux/ptp_clock.h > @@ -67,7 +67,9 @@ struct ptp_perout_request { > struct ptp_clock_time start; /* Absolute start time. */ > struct ptp_clock_time period; /* Desired period, zero means disable. */ > unsigned int index; /* Which channel to configure. */ > - unsigned int flags; /* Reserved for future use. */ > + > +#define PTP_PEROUT_ONE_SHOT BIT(0) > + unsigned int flags; /* Bit 0 -> oneshot output. */
The .flags field doesn't need this comment. The individual BIT macro names should be clear enough, and if not, then comment the macros.
> unsigned int rsv[4]; /* Reserved for future use. */ > }; > > -- > 2.22.0 >
Reviewed-by: Richard Cochran <richardcochran@gmail.com>
| |