Messages in this thread | | | Date | Sat, 17 Aug 2019 08:59:27 -0700 | From | Richard Cochran <> | Subject | Re: [PATCH 1/2] PTP: introduce new versions of IOCTLs |
| |
On Wed, Aug 14, 2019 at 10:47:11AM +0300, Felipe Balbi wrote: > The current version of the IOCTL have a small problem which prevents us > from extending the API by making use of reserved fields. In these new > IOCTLs, we are now making sure that flags and rsv fields are zero which > will allow us to extend the API in the future. > > Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> > --- > drivers/ptp/ptp_chardev.c | 58 ++++++++++++++++++++++++++++++++-- > include/uapi/linux/ptp_clock.h | 12 +++++++ > 2 files changed, 68 insertions(+), 2 deletions(-) > > diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c > index 18ffe449efdf..204212fc3f8c 100644 > --- a/drivers/ptp/ptp_chardev.c > +++ b/drivers/ptp/ptp_chardev.c > @@ -123,9 +123,11 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg) > struct timespec64 ts; > int enable, err = 0; > > + memset(&req, 0, sizeof(req));
Nit: please leave a blank line between memset() and switch/case.
> switch (cmd) { > > case PTP_CLOCK_GETCAPS: > + case PTP_CLOCK_GETCAPS2: > memset(&caps, 0, sizeof(caps)); > caps.max_adj = ptp->info->max_adj; > caps.n_alarm = ptp->info->n_alarm;
Reviewed-by: Richard Cochran <richardcochran@gmail.com>
| |