Messages in this thread Patch in this message | | | From | Chuhong Yuan <> | Subject | [PATCH v2 04/10] module: Replace strncmp with str_has_prefix | Date | Fri, 2 Aug 2019 09:47:03 +0800 |
| |
strncmp(str, const, len) is error-prone because len is easy to have typo. The example is the hard-coded len has counting error or sizeof(const) forgets - 1. So we prefer using newly introduced str_has_prefix to substitute such strncmp.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- Changes in v2: - Revise the description.
kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/module.c b/kernel/module.c index 5933395af9a0..7defa2a4a701 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2251,7 +2251,7 @@ static int simplify_symbols(struct module *mod, const struct load_info *info) switch (sym[i].st_shndx) { case SHN_COMMON: /* Ignore common symbols */ - if (!strncmp(name, "__gnu_lto", 9)) + if (str_has_prefix(name, "__gnu_lto")) break; /* We compiled with -fno-common. These are not -- 2.20.1
| |