Messages in this thread | | | From | Petr Machata <> | Subject | Re: [PATCH][next] mlxsw: spectrum_ptp: fix duplicated check on orig_egr_types | Date | Tue, 30 Jul 2019 11:05:25 +0000 |
| |
Petr Machata <petrm@mellanox.com> writes:
> Colin King <colin.king@canonical.com> writes: > >> From: Colin Ian King <colin.king@canonical.com> >> >> Currently there is a duplicated check on orig_egr_types which is >> redundant, I believe this is a typo and should actually be >> orig_ing_types || orig_egr_types instead of the expression >> orig_egr_types || orig_egr_types. Fix this. > > Good catch, yes, there's a typo. Thanks for the fix! > >> Addresses-Coverity: ("Same on both sides") >> Fixes: c6b36bdd04b5 ("mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled") >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Reviewed-by: Petr Machata <petrm@mellanox.com>
However the patch should address "net", not "next". Can you please respin?
| |