Messages in this thread | | | From | Petr Machata <> | Subject | Re: [PATCH][next] mlxsw: spectrum_ptp: fix duplicated check on orig_egr_types | Date | Tue, 30 Jul 2019 11:00:06 +0000 |
| |
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com> > > Currently there is a duplicated check on orig_egr_types which is > redundant, I believe this is a typo and should actually be > orig_ing_types || orig_egr_types instead of the expression > orig_egr_types || orig_egr_types. Fix this.
Good catch, yes, there's a typo. Thanks for the fix!
> Addresses-Coverity: ("Same on both sides") > Fixes: c6b36bdd04b5 ("mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Petr Machata <petrm@mellanox.com>
> --- > drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c > index 98c5ba3200bc..f02d74e55d95 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c > @@ -999,7 +999,7 @@ static int mlxsw_sp1_ptp_mtpppc_update(struct mlxsw_sp_port *mlxsw_sp_port, > } > } > > - if ((ing_types || egr_types) && !(orig_egr_types || orig_egr_types)) { > + if ((ing_types || egr_types) && !(orig_ing_types || orig_egr_types)) { > err = mlxsw_sp_nve_inc_parsing_depth_get(mlxsw_sp); > if (err) { > netdev_err(mlxsw_sp_port->dev, "Failed to increase parsing depth");
| |