| Subject | Re: [RFC PATCH 04/16] RISC-V: KVM: Implement VCPU create, init and destroy functions | From | Paolo Bonzini <> | Date | Tue, 30 Jul 2019 10:48:36 +0200 |
| |
On 29/07/19 13:56, Anup Patel wrote: > + cntx->hstatus |= HSTATUS_SP2V; > + cntx->hstatus |= HSTATUS_SP2P;
IIUC, cntx->hstatus's SP2P bit contains the guest's sstatus.SPP bit? I suggest adding a comment here, and again providing a ONE_REG interface to sstatus so that the ABI is final before RISC-V KVM is merged.
What happens if the guest executes SRET? Is that EXC_SYSCALL in hedeleg?
(BTW the name of SP2V and SP2P is horrible, I think HPV/HPP or HSPV/HSPP would have been clearer, but that's not your fault).
Paolo
> + cntx->hstatus |= HSTATUS_SPV;
|