Messages in this thread Patch in this message | | | From | Keyur Patel <> | Subject | [PATCH 2/2] staging: most: remove redundant print statement when kfifo_alloc fails | Date | Thu, 11 Jul 2019 07:08:02 -0400 |
| |
This print statement is redundant as kfifo_alloc just calls kmalloc_array and without the __GFP_NOWARN flag, already does a dump_stack().
Signed-off-by: Keyur Patel <iamkeyur96@gmail.com> --- drivers/staging/most/cdev/cdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging/most/cdev/cdev.c index d0cc0b746107..bc0219ceac50 100644 --- a/drivers/staging/most/cdev/cdev.c +++ b/drivers/staging/most/cdev/cdev.c @@ -463,10 +463,9 @@ static int comp_probe(struct most_interface *iface, int channel_id, spin_lock_init(&c->unlink); INIT_KFIFO(c->fifo); retval = kfifo_alloc(&c->fifo, cfg->num_buffers, GFP_KERNEL); - if (retval) { - pr_info("failed to alloc channel kfifo"); + if (retval) goto err_del_cdev_and_free_channel; - } + init_waitqueue_head(&c->wq); mutex_init(&c->io_mutex); spin_lock_irqsave(&ch_list_lock, cl_flags); -- 2.22.0
| |