Messages in this thread | | | Date | Tue, 4 Jun 2019 12:54:46 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v4 01/16] PM / devfreq: tegra: Fix kHz to Hz conversion |
| |
On Thu, May 02, 2019 at 02:38:00AM +0300, Dmitry Osipenko wrote: > The kHz to Hz is incorrectly converted in a few places in the code, > this results in a wrong frequency being calculated because devfreq core > uses OPP frequencies that are given in Hz to clamp the rate, while > tegra-devfreq gives to the core value in kHz and then it also expects to > receive value in kHz from the core. In a result memory freq is always set > to a value which is close to ULONG_MAX because of the bug. Hence the EMC > frequency is always capped to the maximum and the driver doesn't do > anything useful. This patch was tested on Tegra30 and Tegra124 SoC's, EMC > frequency scaling works properly now. > > Cc: <stable@vger.kernel.org> # 4.14+ > Tested-by: Steev Klimaszewski <steev@kali.org> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra-devfreq.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] | |