Messages in this thread | | | Date | Fri, 28 Jun 2019 10:18:46 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] drivers/usb/typec/tps6598x.c: fix two bugs |
| |
On Fri, Jun 28, 2019 at 10:12:35AM +0200, Nikolaus Voss wrote: > 1. Portinfo bit field is 3 bits wide, not 2 bits. This led to > a wrong driver configuration for some tps6598x configurations. > > 2. Writing 4CC commands with tps6598x_write_4cc() already has > a pointer arg, don't reference it when using as arg to > tps6598x_block_write(). Correcting this enforces the constness > of the pointer to propagate to tps6598x_block_write(), so add > the const qualifier there to avoid the warning.
Please split this up into two seprate patches as these are doing two different things.
thanks,
greg k-h
| |