Messages in this thread | | | Date | Fri, 28 Jun 2019 12:58:43 +0300 | From | Heikki Krogerus <> | Subject | Re: [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width |
| |
On Fri, Jun 28, 2019 at 11:01:08AM +0200, Nikolaus Voss wrote: > Portinfo bit field is 3 bits wide, not 2 bits. This led to > a wrong driver configuration for some tps6598x configurations. > > Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers") > Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Shouldn't this be applied to the stable trees as well?
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> --- > drivers/usb/typec/tps6598x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c > index c674abe3cf99..a170c49c2542 100644 > --- a/drivers/usb/typec/tps6598x.c > +++ b/drivers/usb/typec/tps6598x.c > @@ -41,7 +41,7 @@ > #define TPS_STATUS_VCONN(s) (!!((s) & BIT(7))) > > /* TPS_REG_SYSTEM_CONF bits */ > -#define TPS_SYSCONF_PORTINFO(c) ((c) & 3) > +#define TPS_SYSCONF_PORTINFO(c) ((c) & 7) > > enum { > TPS_PORTINFO_SINK, > -- > 2.17.1
thanks,
-- heikki
| |