Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 23 Jun 2019 10:59:18 +0300 | Subject | Re: [PATCH 2/2] Input: edt-ft5x06 - simplify event reporting code |
| |
On Sun, Jun 23, 2019 at 9:31 AM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > Now that input_mt_report_slot_state() returns true if slot is active we no > longer need a temporary for the slot state.
> - down = type != TOUCH_EVENT_UP; > > input_mt_slot(tsdata->input, id); > - input_mt_report_slot_state(tsdata->input, MT_TOOL_FINGER, down);
> + if (input_mt_report_slot_state(tsdata->input, MT_TOOL_FINGER, > + type != TOUCH_EVENT_UP))
Can't we simple do somethink like - down = type != TOUCH_EVENT_UP; + down = input_mt_report_slot_state(tsdata->input, MT_TOOL_FINGER, type != TOUCH_EVENT_UP);
-- With Best Regards, Andy Shevchenko
| |